TYP: fix mypy errors in pandas/core/arraylike.py #39104
Conversation
| @@ -149,7 +149,7 @@ def __rpow__(self, other): | |||
| return self._arith_method(other, roperator.rpow) | |||
|
|
|||
|
|
|||
| def array_ufunc(self, ufunc: Callable, method: str, *inputs: Any, **kwargs: Any): | |||
| def array_ufunc(self, ufunc: np.ufunc, method: str, *inputs: Any, **kwargs: Any): | |||
There was a problem hiding this comment.
np.ufunc currently resolves to Any. I would mothball this PR till we have numpy types.
maybe you could just remove the annotation for now so that the ignores can be removed.
or test this with numpy 1.20.0rc2
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@ivanovmg if you can merge master and update |
|
Thanks @ivanovmg I think the idea is to remove the ignores as they can be seen as a sort of TODO. adding the comment imo does not move this forward. I think if you revert 8b83486. we can then just merge as was. see #39257 (comment) |
This reverts commit 8b83486.
|
looks like @simonjayhawkins 's concerns have been addressed, so LGTM |
|
thanks @ivanovmg |
Handle ignored mypy errors in
pandas/core/arraylike.py.